Opened 10 years ago
Closed 10 years ago
#619 closed task (fixed)
Discuss event_vars and event_file_version
| Reported by: | Juergen Reuter | Owned by: | Juergen Reuter |
|---|---|---|---|
| Priority: | P3 | Milestone: | v2.2.0 |
| Component: | core | Version: | 2.2.0beta |
| Severity: | minor | Keywords: | |
| Cc: |
Description
This is basically a question to WK: it seems that event_vars_t and all usage of it is completely disconnected in 2.2.0 as other (new) data containers are used to store the information. Shall we kepp this in the code or eliminate it? Connected to this is the question of $event_file_version. It was used to distinguish changes in the setup of the raw event format as I believe in version 2.0.0 to 2.0.6 from 2.0.7 to 2.1.1. including. With 2.2.0 it seems to me that ability to read in WHIZARD raw/binary event formats from earlier versions is not possible anyhow. So we could eliminate this flag also. Comments?
Change History (3)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
| Owner: | changed from kilian to Juergen Reuter |
|---|---|
| Status: | new → assigned |
comment:3 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Done in r5512: event_vars completely eliminated. Stub for event_file_version (re-)introduced. Closing.
Ok forgot the connection actually: the event_file_version flag was used to either write or don't write certain parts of info of event_vars_t into the raw event file. Now, the type event_sample_data_t is used for this.