Opened 14 years ago
Closed 14 years ago
#413 closed enhancement (fixed)
Move expensive part of kinematics after cut evaluation
Reported by: | kilian | Owned by: | kilian |
---|---|---|---|
Priority: | P2 | Milestone: | v2.0.6 |
Component: | core | Version: | 2.0.5 |
Severity: | normal | Keywords: | |
Cc: |
Description
Currently, all kinematics and phase space calculations are completed before cuts are evaluated. If the phs point passes cuts, the matrix element is evaluated.
It turns out that the most expensive part of the phs calculation is the evaluation of the integration parameters x_i for all channels other than the current channel. This evaluation uses the momenta that are computed in the current channel. Therefore, this part can be moved after cut evaluation, since the latter needs just the momenta.
I expect that the first few iterations, where the cuts are missed most of the time, get a significant speedup, and OpenMP scales better, if this is implemented. First tests confirm this.
Change History (4)
comment:1 Changed 14 years ago by
Status: | new → assigned |
---|
comment:2 Changed 14 years ago by
SS and JRR have not up to now discovered any deteriorations of the integration behavior compared to the previous setup.
comment:4 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
No problems so far, therefore I remove the flag ?old_phs_version, so the new version is always active (r3267).
The modifications are implemented in r3235. The old version can be reactivated by setting ?old_phs_version=true. This allows comparisons and checks. If we agree that everything works, I will remove the old version.