Opened 7 years ago
Closed 5 years ago
#825 closed defect (duplicate)
eliminate `component%component_type` or reduce it to the minimal amount of information necessary
Reported by: | Juergen Reuter | Owned by: | kilian |
---|---|---|---|
Priority: | P4 | Milestone: | v4.0 |
Component: | core | Version: | 2.5.0 |
Severity: | normal | Keywords: | Refactoring, backlog |
Cc: |
Description
This is issue #4 from gitlab.
Could be steered via component%config%nlo%get_nlo_type () .
JRR looked into this: Looked a little bit into the code. Indeed, this is only marginally used. COMP_RESUM is never used. COMP_SUB, COMP_PDF, COMP_MISMATCH and COMP_VIRT are set, but never used. COMP_REAL is used only to deactive the real component (which is probably right now when use_real_finite is set to true), COMP_MASTER is only used for a tricky hocuspocus for combined integrations, and COMP_REAL_SING and COMP_REAL_FIN are actually used. The first one only for debug output, and to specify the is_subtraction flag. The only one that seems to be really used properly is COMP_REAL_FIN. So this can/should be simplified, maybe even eliminated.
WK's suggestion: Move the information into the process_component_manager(_nlo).
Change History (2)
comment:1 Changed 7 years ago by
Milestone: | v2.6.0 → v4.0 |
---|
comment:2 Changed 5 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Mirrored back to Gitlab.