Opened 11 years ago
Closed 11 years ago
#588 closed defect (fixed)
MCI efficiency not yet calculated
Reported by: | Juergen Reuter | Owned by: | kilian |
---|---|---|---|
Priority: | P1 | Milestone: | v2.2.0 |
Component: | core | Version: | 2.1.1 |
Severity: | normal | Keywords: | |
Cc: |
Description
and another hole ...
Change History (3)
comment:1 Changed 11 years ago by
Priority: | P3 → P2 |
---|---|
Status: | new → assigned |
comment:2 Changed 11 years ago by
Priority: | P2 → P1 |
---|
comment:3 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Done in r5213.
It was not just the efficiency which was missing. chi2 was also not computed. Worst of all, the integral average was computed as if there were no errors, using a wrong formula. The errors should have provided the weights for the average.
Having fixed this, we now again see efficiency and chi2 values which look reasonable. The cross section error after averaging has decreased compared to 2.2 alpha, which restores some faith in the program. The results themselves are slightly modified.
The worst thing was that tons of ref files had to change.
@JR: can you fix the LHAPDF and STDHEP tests if they fail (which I expect)?
Let's hope that this is as straightforward as it looks ...