Opened 11 years ago
Closed 11 years ago
#560 closed defect (fixed)
Reimplement missing commands
Reported by: | Juergen Reuter | Owned by: | kilian |
---|---|---|---|
Priority: | P0 | Milestone: | v2.2.0 |
Component: | core | Version: | 2.1.1 |
Severity: | normal | Keywords: | |
Cc: |
Description (last modified by )
Change History (27)
comment:1 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:4 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:5 Changed 11 years ago by
Priority: | P3 → P2 |
---|
comment:6 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:7 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:8 Changed 11 years ago by
Owner: | changed from kilian to Juergen Reuter |
---|---|
Status: | new → assigned |
comment:9 Changed 11 years ago by
Priority: | P2 → P1 |
---|
comment:10 Changed 11 years ago by
Owner: | changed from Juergen Reuter to kilian |
---|---|
Status: | assigned → new |
comment:11 Changed 11 years ago by
Priority: | P1 → P0 |
---|
comment:12 Changed 11 years ago by
I see the cause of the problem, but don't yet have a solution.
[I admit that my variable handling module is _really_ broken (partly due to the absence of proper type extension). But I won't open another bottle by rewriting it now ;) ... rather try to find a workaround, again.]
comment:13 Changed 11 years ago by
tolerance parameter (r5064): this was actually ok, but I unified the comparison operators in Sindarin according to the discussion on the phone.
Comparison (==, <>, <, >, <=, >=) now takes into account the tolerance
parameter if a real number is involved in the comparison. By default, the tolerance is zero, of course. The operators (==~ and <>~) have disappeared, they are redundant.
comment:15 Changed 11 years ago by
Owner: | changed from kilian to Juergen Reuter |
---|---|
Status: | new → assigned |
Ok, it seems magically both is present. I don't know why. Adding the missing cases (as no one reacted).
comment:16 Changed 11 years ago by
Owner: | changed from Juergen Reuter to kilian |
---|---|
Status: | assigned → new |
WK, can you take over again, please? (you know what I want: as many of the things in vars.sin should work again)
comment:17 Changed 11 years ago by
Again, my thinking here was to cover as much as possible from the vars.sin test by the implemented commands. So, WK: 1) if there is stuff in vars.sin you think should never be reenabled, please remove it from
that SINDARIN file
2) if there is stuff that will be disabled for now but be covered in the planned year 2063
revision of SINDARIN () then comment it out (and make a comment in vars.sin)
Thanks again and sorry for the weekend disturbances.
comment:18 Changed 11 years ago by
status for command scan: done, but fighting a segfault that occurs with gfortran only (arghh...)
comment:19 Changed 11 years ago by
Priority: | P0 → P1 |
---|
comment:20 Changed 11 years ago by
Priority: | P1 → P0 |
---|
comment:21 Changed 11 years ago by
WK, please, please, PLEASE, let me know whether you will do the show(real), show(int), show(intrinsic), show(logical) or not?
comment:22 Changed 11 years ago by
Hmm - I'm still not convinced. Could you suggest 'show' variants that are *actually* useful?
In any case, I would do it (easy), but I prefer to do the other missing commands first, and collect wishes for 'show' in the meantime.
comment:23 Changed 11 years ago by
Show stopper: show done finally in r5107 (all that JRR wanted to have into). Actually, show (alias XXX) was broken in cmd_show_compile. Fixed that, and added a new test show_4 that tests for it, and the other features.
comment:24 Changed 11 years ago by
Actually, in r5108 I added logical and string test cases. WK, please reassign now for the missing tests.
comment:25 Changed 11 years ago by
Ok, JRR will fix that issue (making the test intrinsic). Give me 10-15 mins. Sorry.
comment:26 Changed 11 years ago by
r5113: removed the timing me_test command (matrix_element_test
), superseded by providing n_calls_test
to the integrate
command. (If phs_only
is set, only the test will be run, after phase-space configuration.)
comment:27 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
As of r5161, all commands have been either deleted, replaced, or resurrected. Any further additions would count as new features.
[1. printf done in r5090] [2. show done in r5048 ... and finally in r5107] [3. scan done in r5085] [4. include was already implemented] [5. scale done in r4977] [6. ren_scale done in r4977] [7. fac_scale done in r4977] [8. tolerance done in r5064] [9. quit done in r4968] [10. exec done in r4992] [11. slha done in r5046 (separate ticket #519)] [12. weight done in r4977] [13. selection done in r4982] [14. reweight done in r4978] [15. clear done in r5056] [16. open_out/close_out done in r5090 (separate tickets #571, #542)] [17. me_test done in r5113] [18. beam_polarization done in r5161 (separate ticket #559)]