whizard is hosted by Hepforge, IPPP Durham

Opened 11 years ago

Closed 9 years ago

#514 closed defect (fixed)

Fix definition of quadruple precision

Reported by: Juergen Reuter Owned by: ohl
Priority: P1 Milestone: v2.2.8
Component: configure Version: 2.1.1
Severity: normal Keywords:
Cc:

Description

THe quadruple precision defined in the kinds.f90 module is indeed only a 10byte precision.

Change History (13)

comment:1 Changed 11 years ago by Juergen Reuter

There is one issue in the LHAPDF structure function:

libtool: compile:  gfortran -I../misc -I../vamp/src -I../shower -I../pdf_builtin -I../muli -I../circe1/src -I../circe2/src -fopenmp -g -O2 -c sf_pdf_builtin.f90  -fPIC -o .libs/sf_pdf_builtin.o
sf_lhapdf.f90:535.49:

               call evolvePDFphotonM (data% set, x, qq, ff(6:-6:-1), fphot)
                                                 1
Error: Type mismatch in argument 'x' at (1); passed REAL(10) to REAL(8)
sf_lhapdf.f90:541.49:

               call evolvePDFphotonM (data% set, x, qq, ff, fphot)
                                                 1
Error: Type mismatch in argument 'x' at (1); passed REAL(10) to REAL(8)

comment:2 Changed 11 years ago by Juergen Reuter

One idea I have is the following: for some of the tests we might make them conditional on the precision and maybe give different reference files for double and quadruple precision. What do you think?

comment:3 in reply to:  1 Changed 11 years ago by Juergen Reuter

Replying to jr_reuter:

There is one issue in the LHAPDF structure function:

libtool: compile:  gfortran -I../misc -I../vamp/src -I../shower -I../pdf_builtin -I../muli -I../circe1/src -I../circe2/src -fopenmp -g -O2 -c sf_pdf_builtin.f90  -fPIC -o .libs/sf_pdf_builtin.o
sf_lhapdf.f90:535.49:

               call evolvePDFphotonM (data% set, x, qq, ff(6:-6:-1), fphot)
                                                 1
Error: Type mismatch in argument 'x' at (1); passed REAL(10) to REAL(8)
sf_lhapdf.f90:541.49:

               call evolvePDFphotonM (data% set, x, qq, ff, fphot)
                                                 1
Error: Type mismatch in argument 'x' at (1); passed REAL(10) to REAL(8)

This has been resolved in r4620.

comment:4 Changed 11 years ago by Juergen Reuter

Milestone: v2.2.0v2.2.1

comment:5 Changed 11 years ago by Juergen Reuter

Milestone: v2.2.1v2.2.2

comment:6 Changed 11 years ago by Juergen Reuter

Plan: what is now quadruple should be renamed into extended (incl. self tests). TO's program should be incorporated into fortran.m4 and provide the precision decision. In case true quadruple prec. will be supported there will be a third set of reference files, and then NAG vs. gfortran shall be tested. JRR will do the trivial renaming soon-ish ...

comment:7 Changed 10 years ago by Juergen Reuter

Milestone: v2.2.3v2.2.4

The renaming is actually done since quite a while now. The rest is still pending.

comment:8 Changed 10 years ago by Juergen Reuter

Milestone: v2.2.5v2.2.6

What is the status about this? TO promised to do something concerning the determination of precision.... but nothing ever happened!! Will be, however, earliest in milestone 2.2.6.

comment:9 Changed 10 years ago by Juergen Reuter

Milestone: v2.2.6v2.2.7

comment:10 Changed 10 years ago by Juergen Reuter

Component: coreconfigure

comment:11 Changed 10 years ago by Juergen Reuter

Priority: P4P1

comment:12 Changed 9 years ago by Juergen Reuter

Milestone: v2.2.7v2.2.8

comment:13 Changed 9 years ago by Juergen Reuter

Resolution: fixed
Status: newclosed

After all tests run (including cross-compilation, thanks to TO) all (known) issues are caught and included, and this ticket can be closed.

Note: See TracTickets for help on using tickets.