Opened 13 years ago
Closed 11 years ago
#468 closed task (fixed)
Restore full functionality of 2.1.1.
Reported by: | kilian | Owned by: | kilian |
---|---|---|---|
Priority: | P4 | Milestone: | v2.2.0 |
Component: | core | Version: | 2.1.1 |
Severity: | critical | Keywords: | |
Cc: |
Description (last modified by )
I started revising the modules that handle process libraries and processes. Several problems with the old code make this necessary.
The first check-in with work-in-progress is r4027.
Goals:
- Handle matrix elements of arbitrary kinds (internal, external, hand-written, etc.) by a common process object.
- Multiple components of a process (some of them may be automatically generated, such as dipole subtractions).
- Remove unnecessary hard-coded assumptions, such as the use of VAMP for integration.
- Separate interface from implementation. For instance, all OMega-specific stuff is now in a separate module that extends a couple of abstract generic types.
- All new code should be covered by unit tests from the beginning, as far as it makes sense.
The original motivation was:
For various applications (in particular, NLO), a process has multiple subprocesses with kinematics and event samples that are partly common, partly separate. The process object has to be extended such as to properly handle those.
Change History (52)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
No. We agreed that I'll review CS's mods and maybe rewrite the process object in a more transparent way.
comment:4 Changed 13 years ago by
Milestone: | v2.1.0 → v2.0.8 |
---|---|
Severity: | major → critical |
comment:5 Changed 13 years ago by
Would be great, WK, if you could revisit this. Because: then, we could go and merge this with the trunk while I'm visiting CS in Freiburg in 2 weeks.
comment:6 Changed 13 years ago by
Milestone: | v2.0.8 → v2.1.0 |
---|
comment:7 Changed 13 years ago by
Milestone: | v2.1.0 → v2.2.0 |
---|
comment:8 Changed 13 years ago by
Milestone: | v2.2.0 → v2.1.2 |
---|
comment:9 Changed 12 years ago by
Milestone: | v2.1.2 → v2.1.1 |
---|
Actually, this becoming one of the major stumbling stones for the project! It should be resolved at best before the next meeting!!!
comment:10 Changed 12 years ago by
Milestone: | v2.1.1 → v2.1.2 |
---|
comment:11 Changed 12 years ago by
This issue is directly connected to the recent merge of the NLO infrastructure. The process object and its components have to be properly (re)structured, incorporating the NLO additions and allowing for present and future extensions. This task requires a major rewrite of (part of, at least) the process-object related code.
Until this is done, don't expect the system to function properly. Currently, WHIZARD compiles, and basic tests and processes do work, but the decay and structure-function parts are defective.
comment:12 Changed 12 years ago by
Priority: | P0 → P1 |
---|
As long as #468 is under construction, this has to be postponed again.
comment:13 Changed 12 years ago by
Priority: | P1 → P0 |
---|---|
Status: | new → assigned |
Wrong ticket rated down, correction ...
comment:15 Changed 12 years ago by
Since you're asking:
I have agreed (with myself) on a new, much better structured process record. The functionality won't really change, but it is tedious to go through all subobjects and sub-subobjects to implement that change. I'm working with a temporary GIT repository locally, as ThO suggested. This means that I will touch the svn repository only once in a while. If anybody has urgent unrelated changes to whizard.nw, I can pull them in and keep up to date.
comment:18 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Summary: | Multiple subprocesses within a process object → Rework process and process library handling |
comment:19 Changed 12 years ago by
At least with gfortran 4.8.0 there is an ICE :( Will test today 4.5.x, 4.6.x, 4.7.x
comment:21 Changed 12 years ago by
Priority: | P1 → P0 |
---|
comment:22 Changed 12 years ago by
Puh, this looks like a mess now. Looks like that this can be combined with #327 now.
comment:23 Changed 12 years ago by
Not yet. My current work is admittedly too slow, but still localized.
comment:25 Changed 12 years ago by
comment:26 Changed 12 years ago by
Version: | 2.0.6 → 2.1.1 |
---|
comment:27 Changed 12 years ago by
Summary: | Rework process and process library handling → Getting bits and pieces together ... |
---|
Process and process handling is done in OO form. Now, everything has to be reenabled and all features have to be reimplemented or switched on again (incl. proper testing!).
comment:28 Changed 12 years ago by
Seems we are getting closer ... but SINDARIN steering is not yet back!
comment:29 Changed 12 years ago by
With r4272, Sindarin input can be parsed again. I will continue by resurrecting a few commands that implement minimal functionality: integration of a test process.
comment:30 Changed 12 years ago by
[read the fine print: right now, ALL Sindarin commands are still deactivated, so don't try ...]
comment:31 Changed 12 years ago by
A bit more has been reactivated now, but still no trivial things doable. JRR will step in at the earliest feasible point (for structure functions and event formats).
comment:32 Changed 12 years ago by
Summary: | Getting bits and pieces together ... → Restore full functionality of 2.1.1. |
---|
Most of the code is functional again, though there still is a segmentation fault when reading in a process defintion in the SINDARIN file. Now, it is important to restore the full functionality of 2.1.1.
comment:34 Changed 11 years ago by
r4413: Finally, we can compute integrals for real processes. Still far from full functionality. Here is a sketchy priority list:
- Reactivate more of VAMP, in particular event generation and Grid I/O
- Structure functions, at least for LHC processes
- Event I/O
This may qualify for an alpha version.
- Reactivate Sindarin constructs (many are currently disabled)
- Recovery tools (re-reading of input, MD5 sums etc.)
- More features of 2.1.1
Another milestone. Maybe release as beta with reduced functionality.
- Remaining structure functions
- Decays and correlations
Qualify for beta or experimental release.
- Possibly new features: process containers etc.
- Complete features, tests etc.
Release.
comment:35 Changed 11 years ago by
- almost done. 6a: Analysis. 8a. Shower and Pythia-Interface incl. MLM-Matching.
comment:36 Changed 11 years ago by
status 13/08/22:
- Reactivate VAMP: done
- Structure functions for LHC: PDF builtin done, LHAPDF w.i.p.
- Event I/O: raw format done, other formats not yet.
- Reactivate Sindarin: various variables and commands; control structures not yet.
- Recovery tools: raw event files done, MD5 sums not yet.
comment:37 Changed 11 years ago by
status 28/08: we are moving to the stage where we list things that don't work (yet), instead of listing a few features that do work. The next step is splitting off the subset of features that must be present in an alpha version. We are close, actually.
comment:38 Changed 11 years ago by
Priority: | P0 → P4 |
---|
comment:39 Changed 11 years ago by
The following commands should be reinstated for 2.2.0:
- beam_polarization
- close_out (#542)
- exec
- expect
- fac_scale
- matrix_element_test (maybe rename)
- open_out (cf. #542)
- polarized (cf. #518)
- printf
- quit
- ren_scale
- reweight
- scale
- scan
- selection
- show
- stable (cf. #518)
- unpolarized (cf. #518)
- unstable (cf. #518)
- slha
- weight
To be deleted:
- load
- printd
- histogram_writer, plot_writer
- CS's NLO customs
JRR will delete, WK will re-create ...
comment:41 Changed 11 years ago by
In r4720, histogram_writer and plot_writer and CS NLO customs are gone. They will be reimplemented by WK and CW, respectively. There are still some leftovers which we will have to discuss like get_analysis_tags etc.
comment:42 Changed 11 years ago by
This includes a final check of the attic code and whether everything is in the program ...
comment:43 Changed 11 years ago by
Ok. let me start a list of things to be discussed:
- grove_weights
- (equiv. of) core_interaction_write_summary (summary of quantum number states)
- process_status_counter: passed cuts, etc.
- handling of negative weights (was bookkeeping up to now, I would say)
- check use of 'use tao_random_numbers'
- check lots of unused 'use XXX' in commands.f90
[ 7. ?polarized_events flag: only used (afaik) for the simulation message. (was actually
also for setting the FM_XXX_HELICITY mode, done in r5263]
[ 8. FORBIDDEN_ENDINGS check and file taken from file_list for analysis framework (in
cmd_write_analysis_compile). This should be checked and reinstated (done in r5249)]
[ 9. same for the error tags and the comment tags (though there is a separate ticket
#542)]
[10. name expression in cmd_write_analysis has to be reinserted (separate ticket #604)]
- Several occasions where gfortran 4.6.3/4 bugs have been evaded. All that can be
reverted as we are considering versions >= 4.7.1 now anyhow.
[12. Remove undefined noweb chunks]
- Reinsert MAX_TRIES_FOR_SINGLE_EVENT
[14. libraries variable in main.f90]
- check for "call mask_term_signals"
- Chech that relocation scripts are still working properly ...
- Discuss and check the rationale of this ticket above ...
- What about the subroutine particle_set_fill_hepmc_event ?
- Dito for particle_init_hepmc ...
- Dito for hepmc_test ...
[21. A lot of chunk (commented out stuff) in integrations.f90 ... separate ticket #610]
- Reinstate the "event normalization" message (also in the default case) (?)
- Check numerical noise in weight adaptation (32 vs. 64bit)
- Check "gw", "g", "w", "" options
comment:44 Changed 11 years ago by
This message
|=============================================================================| | vamp: parameter mismatch, discarding grid file 'beam_setup_1p.vg'
appears also for a new integration. It is just cosmetics ... But maybe we could do something about it.
comment:45 Changed 11 years ago by
The re-implementation of the graph command might still be incomplete, should check this.
comment:46 Changed 11 years ago by
Several maintenance steps: beam_fmt eliminated, process_library_check_name_consistency no longer needed (checked), also I introduced a WHIZARD bug message for the case that the mci_integral is not known.
comment:47 Changed 11 years ago by
Next step: veto against flavor sums with different masses has been reenabled.
comment:48 Changed 11 years ago by
I actually checked that special MD5 sums for SF parameters are not needed. Changing them correctly leaves the PHS untouched, but the VAMP grids are newly built. Also, min_calls_per_bin and min_calls_per_channel have been reactivated.
comment:49 Changed 11 years ago by
Priority: | P4 → P1 |
---|---|
Status: | assigned → new |
I'll see through this list tomorrow. Points left open should also be discussed on Monday, if possible.
comment:50 Changed 11 years ago by
Status: | new → assigned |
---|
comment:51 Changed 11 years ago by
Priority: | P1 → P4 |
---|
All remarks above are closed, a.t.m. the only left-over is
A check of the relocation scripts.
comment:52 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Left-over went into a separate ticket. Closing
Somehow this ticket slipped through... Is that not done when we merge CSs branch?