Opened 15 years ago
Closed 15 years ago
#349 closed defect (fixed)
Wrong code in pythia used by the matching module
Reported by: | Juergen Reuter | Owned by: | dwiesler |
---|---|---|---|
Priority: | P2 | Milestone: | v2.0.3 |
Component: | interfaces | Version: | 2.0.2 |
Severity: | critical | Keywords: | wrong FORTRAN code |
Cc: |
Description
There are a plethora of code statements in the matching routines which do not compile with the NAG compiler, i.e. already the make process fails. (cf. the HUDSON messages)
Change History (4)
comment:1 Changed 15 years ago by
Priority: | P1 → P2 |
---|---|
Severity: | blocker → critical |
Summary: | Wrong code in matching module → Wrong code in pythia used by the matching module |
comment:2 Changed 15 years ago by
I tried to correct some obvious errors in pythia and finally found myself digging much to deep into a hell of bad code:
[NAG Fortran Compiler error termination, 99 errors, 1259 warnings]
Therefore I opt for documenting this in the manual and enabling pythia only for gfortran compiler versions.
comment:3 Changed 15 years ago by
Status: | new → assigned |
---|
In r2736 I changed a few culprits in pythia, this should in principle solve the ticket issue. Waiting for a senior to confirm before closing ...
comment:4 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
There was one other issue, namely that (re-)compilation of PYTHIA from the MIISR directory had the same problem. I transferred Daniel's solution. But this is hacking here, MIISR should use, but not re-compile PYTHIA. We shall keep this in mind for 2.0.4. or so. For now, closing this ticket. (ThO, if you have a good and quick idea, please step in.)
Solved the three bugs within the interface code in r2734.
The problem now is faulty pythia code. We should decide wether to fix this (and probably loose the possibility of automated svn updating to the recent pythia versions) or keep it this way and document it in the manual to only use gfortran for compiling pythia.