Opened 14 years ago
Closed 13 years ago
#340 closed defect (fixed)
Order of command instructions relevant in integration vs. simulation
| Reported by: | sschmidt | Owned by: | kilian |
|---|---|---|---|
| Priority: | P3 | Milestone: | v2.0.5 |
| Component: | core | Version: | 2.0.2 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
The settings for the parton shower I implemented are ignored if they appear in the sin-file after the integrate statement. It would be intuitive only to request the parton shower settings before simulate but not before integrate.
Attachments (1)
Change History (11)
Changed 14 years ago by
| Attachment: | ticket340.sin added |
|---|
comment:1 Changed 14 years ago by
| Milestone: | → v2.0.3 |
|---|
comment:2 Changed 14 years ago by
| Milestone: | v2.0.3 → v2.1 |
|---|
The parton shower shouldn't be (officially) implemented up to 2.1, until then the settings can be ignored ;-).
AFAIK there are no other parts of the programm affected.
comment:3 Changed 13 years ago by
Could someone tell me what the status of this ticket is??? As the shower as now at least alpha status, this has some relevance...
comment:4 Changed 13 years ago by
the status is that nobody worked on it (as far as I know), and in the input file above the shower settings are still ignored.
comment:5 Changed 13 years ago by
Tried to look into that one.... but don't know enough about the shower to see what happens (or happens not) here.
comment:6 Changed 13 years ago by
I looked a bit into that one. That is something we could decide/do more or less now, I guess. (And should, as the shower is moving from alpha to beta status soon) Indeed, the settings for the parton shower are ignored if the corresponding statement appears only after the integrate command. (The same is true for the structure function settings, e.g. lepton ISR, EPA, etc.) But isn't that what it should be meant to, actually? You should set the stuff for a process before you integrate it. Ok, granted, you could say, the shower is something only relevant for simulation, and hence, the settings should be possible to be set after the integration but in ahead of the simulate command. Please let us discuss this. If we agree the settings to be there in the second case, I think there is a solution to that. But let's decide on that one quickly.
comment:7 Changed 13 years ago by
I think a user would expect shower settings to work as long as they are located before the simulate command, at least I would. Furthermore, when opening this ticket I assumed it would only be a rather trivial change to the parser, I don't know enough about the parser though.
comment:8 Changed 13 years ago by
| Milestone: | v2.1.0 → v2.0.5 |
|---|
comment:9 Changed 13 years ago by
| Summary: | Settings for the parton shower are ignored → Order of command instructions relevant in integration vs. simulation |
|---|
comment:10 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The shower_settings data block belongs to the simulation data. Moving it there solved the problem (r3195)
example simplest ISR sin file