#206 closed defect (fixed)
share/test/Makefile.am and/or test/Makefile.am modify $(srcdir)
| Reported by: | Juergen Reuter | Owned by: | ohl |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Component: | configure | Version: | 2.0.0rc2 |
| Severity: | critical | Keywords: | structure |
| Cc: |
Description (last modified by )
Makefiles must respect the separation of $(srcdir) and $(builddir).
test/Makefile.am share/test/Makefile.am
should be properly autotoolized. If there is foo.m4, then foo.sin should not be in $(srcdir).
Change History (15)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Now it seems to work up to those permission errors which do not do any harm (cf. below). Problem is that I have to go exclusively via the srcdir and omit the builddir, because otherwise I have to copy files over again, which is bullshit.
/usr/bin/m4 ../../../share/test/testsuite.m4 ../../../share/test/mssmtest-ee2.m4 > ../../../share/test/mssmtest-ee2.sin /bin/sh: ../../../share/test/mssmtest-ee2.sin: Permission denied make[3]: [mssmtest-ee2.sin] Error 1 (ignored) /usr/bin/m4 ../../../share/test/testsuite.m4 ../../../share/test/mssmtest-en.m4 > ../../../share/test/mssmtest-en.sin /bin/sh: ../../../share/test/mssmtest-en.sin: Permission denied make[3]: [mssmtest-en.sin] Error 1 (ignored) /usr/bin/m4 ../../../share/test/testsuite.m4 ../../../share/test/mssmtest-tt.m4 > ../../../share/test/mssmtest-tt.sin /bin/sh: ../../../share/test/mssmtest-tt.sin: Permission denied make[3]: [mssmtest-tt.sin] Error 1 (ignored) /usr/bin/m4 ../../../share/test/testsuite.m4 ../../../share/test/mssmtest-tn.m4 > ../../../share/test/mssmtest-tn.sin /bin/sh: ../../../share/test/mssmtest-tn.sin: Permission denied make[3]: [mssmtest-tn.sin] Error 1 (ignored)
comment:3 Changed 14 years ago by
| Description: | modified (diff) |
|---|---|
| Priority: | P1 → P3 |
| Severity: | blocker → normal |
| Summary: | make distcheck is broken by m4 -> sin conversion → Remove ugliness from share/test Makefile.am |
it's working. About the rest I don't care. Now someone who knows Autotools better has to clean up the mess :-s .
comment:4 Changed 14 years ago by
| Priority: | P3 → P1 |
|---|
Maybe its better to address this before it affects anything else!!!
comment:5 Changed 14 years ago by
| Summary: | Remove ugliness from share/test Makefile.am → Updating of the .m4 files is also not working |
|---|
oK, this is a show stopper, updating of the m4 files does not work. I'm done with that f*ing autotools. They are way above me.
comment:6 Changed 14 years ago by
| Owner: | changed from ALL to ohl |
|---|---|
| Severity: | normal → critical |
| Status: | new → assigned |
OK, I'll try to fix that. But no promises before Monday.
comment:7 Changed 14 years ago by
as of r1787 (autoreconf!), the m4 action has been moved to a branch
branches/ohl/properly-autotoolize-tests
and the trunk compiles again.
comment:8 Changed 14 years ago by
Don't know whether this was wise. Sometimes it's better to have progress than to have the trunk compiling. Now my tests are screwed. I really hate it.
comment:9 Changed 14 years ago by
| Summary: | Updating of the .m4 files is also not working → Streamlining of Makefiles for .m4 -> .sin conversion |
|---|
comment:10 Changed 14 years ago by
The updating of .m4 -> .sin files seems to work when the .m4 files get affected.
comment:11 Changed 14 years ago by
| Description: | modified (diff) |
|---|---|
| Priority: | P1 → P2 |
| Summary: | Streamlining of Makefiles for .m4 -> .sin conversion → share/test/Makefile.am and/or test/Makefile.am modify $(srcdir) |
See the new description.
Don't panic. I'll fix this.
comment:13 Changed 14 years ago by
This should especially abandon this ugly repetitious copying of files:
test -f "mssmtest-ee.sin" || cp ../../share/test/mssmtest-ee.sin mssmtest-ee.sin test -f "mssmtest-en.sin" || cp ../../share/test/mssmtest-en.sin mssmtest-en.sin test -f "mssmtest-tt.sin" || cp ../../share/test/mssmtest-tt.sin mssmtest-tt.sin test -f "mssmtest-tn.sin" || cp ../../share/test/mssmtest-tn.sin mssmtest-tn.sin test -f "mssmtest-ww.sin" || cp ../../share/test/mssmtest-ww.sin mssmtest-ww.sin test -f "mssmtest-wz.sin" || cp ../../share/test/mssmtest-wz.sin mssmtest-wz.sin test -f "mssmtest-wa.sin" || cp ../../share/test/mssmtest-wa.sin mssmtest-wa.sin test -f "mssmtest-zz.sin" || cp ../../share/test/mssmtest-zz.sin mssmtest-zz.sin test -f "mssmtest-za.sin" || cp ../../share/test/mssmtest-za.sin mssmtest-za.sin test -f "mssmtest-aa.sin" || cp ../../share/test/mssmtest-aa.sin mssmtest-aa.sin test -f "mssmtest-ga.sin" || cp ../../share/test/mssmtest-ga.sin mssmtest-ga.sin test -f "mssmtest-gz.sin" || cp ../../share/test/mssmtest-gz.sin mssmtest-gz.sin test -f "mssmtest-gw.sin" || cp ../../share/test/mssmtest-gw.sin mssmtest-gw.sin test -f "mssmtest-gg.sin" || cp ../../share/test/mssmtest-gg.sin mssmtest-gg.sin test -f "mssmtest-uu.sin" || cp ../../share/test/mssmtest-uu.sin mssmtest-uu.sin test -f "mssmtest-dd.sin" || cp ../../share/test/mssmtest-dd.sin mssmtest-dd.sin test -f "mssmtest-bb.sin" || cp ../../share/test/mssmtest-bb.sin mssmtest-bb.sin test -f "mssmtest-bt.sin" || cp ../../share/test/mssmtest-bt.sin mssmtest-bt.sin make all-am
Specifically a broken make distcheck means THAT ALL OTHER ACTIVITIES have to stop before that problem is settled. This absolutely highest priority.