whizard is hosted by Hepforge, IPPP Durham

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#151 closed defect (fixed)

errors.sin gives XPASS, not XFAIL on MAC OS X. Why?

Reported by: Juergen Reuter Owned by: ALL
Priority: P1 Milestone:
Component: configure Version: 2.0.0beta
Severity: blocker Keywords:
Cc:

Description

On my trunk version this is not the case. Can it be connected with the export of the variables for the libraries???? I have no clue.

Change History (7)

comment:1 Changed 15 years ago by Christian Speckner

Sounds more like some flavour of r1571 returning from the grave.

comment:2 Changed 15 years ago by Juergen Reuter

OK, also inserting something like bla = "fusel" (i.e. assigning a string to a numeric type, which triggers a fatal) does not change XPASS -> XFAIL. So, probably the status of WHIZARD is somehow wrong for aborting the program. Why is this only on MAC? Is it connected with my fix on the export of the PATHs. CS, could you please check on the status from the test/Makefile scripts on the checks!?

comment:3 Changed 15 years ago by Juergen Reuter

it is the export statement after the whizard call in the test case of run_whizard_sh. It seems that WHIZARD takes the status of the export call. *grmpf*

comment:4 Changed 15 years ago by kilian

Of course, the exit status is the exit status of the last command in the script. You could save the status and call some shell EXIT command at the end.

BTW: To clean this up a bit, the path stuff in run_whizard.sh should be used only when we really need it (MAC oS). Configure should be able to detect this and set a variable that can be used within the script.

comment:5 Changed 15 years ago by kilian

... why do you have these lines at all?

  ###
  ###
  DYLD_LIBRARY_PATH=${DYLD_TMP}
  export DYLD_LIBRARY_PATH
  ###

The export applies only to a subshell, not to the parent, so these lines are no-ops.

comment:6 Changed 15 years ago by Juergen Reuter

Resolution: fixed
Status: newclosed
Summary: OMG, now: errors.sin gives XPASS, not XFAIL on MAC OS X. Why?errors.sin gives XPASS, not XFAIL on MAC OS X. Why?

This was the exit status from the export statement, cf. PR #135. Solved finally in r1589. Closing.

comment:7 Changed 15 years ago by Juergen Reuter

Milestone: v2.0.0final

Milestone v2.0.0final deleted

Note: See TracTickets for help on using tickets.