Opened 14 years ago
Last modified 11 years ago
#418 closed defect
W1 option take-over into W2 — at Version 59
Reported by: | Juergen Reuter | Owned by: | kilian |
---|---|---|---|
Priority: | P1 | Milestone: | v2.2.0 |
Component: | core | Version: | 2.0.5 |
Severity: | normal | Keywords: | W1 -> W2 options |
Cc: |
Description (last modified by )
- events_per_file, including starting number, for some formats
implemented in 2.1, not yet in 2.2
- keep best grid as fall back option like W1
- allow to ignore checksum test
obsolete:
- use_efficiency (efficiency fluctuates)
- time_limit_adaptation (dangerous and machine dependent)
- generate_phase_space (old development flag)
- write_phase_space_channels_file
- extra_off_shell_lines
- splitting_depth (only single logs, not important)
- single/double_off_shell_branchings/decays
- massive_fsr
- single/double_off_shell_branchings/decays
- write_weights/write_weights_file
- guess_color_flow
- pythia_processes
- time_limit (only for hard nosed batch systems)
- warn_empty_channel (only for pathological cases)
- show_pythia_initialization
- show_pythia_statistics
- screen_events, screen_histograms
- screen_diagnostics
- plot_grids_channels, plot_grids_logscale (impractical for large number of channels?)
Change History (59)
comment:1 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:4 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:5 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:6 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:7 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:8 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:9 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:10 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:11 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:12 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Priority: | P3 → P1 |
comment:13 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:14 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:15 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:16 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:17 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:18 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:19 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:20 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:21 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:22 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:23 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:24 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:25 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:26 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:27 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:28 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:29 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Summary: | Discuss W1 option take-over into W2 → W1 option take-over into W2 |
comment:30 Changed 13 years ago by
Milestone: | v2.0.6 → v2.0.7 |
---|
comment:31 Changed 13 years ago by
Milestone: | v2.1.0 → v2.0.7 |
---|
comment:32 Changed 13 years ago by
Owner: | changed from ALL to kilian |
---|
comment:33 Changed 13 years ago by
Status: | new → assigned |
---|
comment:34 Changed 13 years ago by
accuracy_goal: done in r3658.
There are now three goals: accuracy_goal, error_goal, relative_error_goal. If all goals that are set have been reached in the adaptation pass, the rest of the adaptation pass is skipped and WHIZARD proceeds with the final integration pass.
The nontrivial part was to make this work correctly with iterations read from file. They are reused where possible, even if the goals are changed in a second run.
comment:35 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:36 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:37 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Priority: | P1 → P3 |
comment:38 Changed 13 years ago by
Type: | enhancement → defect |
---|
Those are actually defects as features that have been damaged or crippled.
comment:39 Changed 13 years ago by
Milestone: | v2.0.7 → v2.0.8 |
---|
comment:43 Changed 13 years ago by
Milestone: | v2.0.8 → v2.1.0 |
---|
comment:44 Changed 12 years ago by
Milestone: | v2.1.1 → v2.1.2 |
---|
comment:45 Changed 12 years ago by
Milestone: | v2.2.0 → v2.2.1 |
---|
comment:46 Changed 12 years ago by
After the upgrade from WHIZARD 2.1.x to 2.2.0 we have to recheck again that all these options are in :(
comment:47 Changed 12 years ago by
Milestone: | v2.2.1 → v2.2.0 |
---|
comment:48 Changed 11 years ago by
Milestone: | v2.2.0 → v2.2.1 |
---|
comment:51 Changed 11 years ago by
Cool. And please don't forget to re-check those features marked as implemtented here again.
comment:52 Changed 11 years ago by
Description: | modified (diff) |
---|
r4981 covers
- safety_factor, flag events w/weight > 1 (plot_excess)
Event weight excess in rejection (unweighting) is now always recorded and displayed at the end of the simulation pass. A safety_factor
may be given to the simulate
command to reduce the acceptance probability and thus reduce excess. Event excess can be separately plotted using record_excess
. This offers more flexibility than the W1 version, where it was always plotted on top of the unweighted events. (Assuming that the drawing options will be improved in future versions, anyway.)
comment:53 Changed 11 years ago by
Description: | modified (diff) |
---|
Partially done:
- events_per_file, including starting number
Implemented for the eio_ascii set of formats. The global variables are sample_split_n_evt
and {{sample_split_index}}}. Not yet implemented for other formats, but this should be straightforward. the relevant TBP is called eio_split_out
.
Also done:
- signal handling: save/restore vamp grid CONTENTS
Signals are blocked by default. At important points in code, the signal status is queried by signal_is_pending
and, if necessary, the current routine returns. This works like a poor-man's exception mechanism. The actual termination points are after each SINDARIN command. (In the cascades module, I kept termination points as they were before.)
This way of treating signals allows to do some cleanup, such as properly closing event files, before the program aborts. In the previous implementation, there was only the possibility of immediate abort at various points.
The issue of snapshooting VAMP is nontrivial. I deferred this to #572.
There are no tests for signal handling; this is difficult. Practice should show whether I missed something.
comment:54 Changed 11 years ago by
event file splitting: covered LHEF in r4989.
Not yet covered: stdhep and HepMC.
comment:55 Changed 11 years ago by
Description: | modified (diff) |
---|
- show_* for debug output format
done in r4998. The user variables are ?debug_process
for displaying the hard process instance, ?debug_decay
for displaying the decay chain, and ?debug_verbose
. A more fine-grained control seems unnecessary (for me), but may be added later.
comment:56 Changed 11 years ago by
I rechecked the fragmentation/fragmentation_method. THis was mainly an opion for 1. no hadronization, 2. jetset with guessed color flows (which we don't need), PYTHIA hadronization (steered with the interface), 4. user defined hadronization (who wants this?) So this is indeed obsolete from our perspective now.
comment:57 Changed 11 years ago by
Description: | modified (diff) |
---|
So, I remove fragmentation from the list. The issue behind it is covered in ticket #44.
comment:58 Changed 11 years ago by
Description: | modified (diff) |
---|
- plot_width, plot_height
This was already there, but called graph_width_mm
and graph_height_mm
. I expanded a unit test (commands_23) where this is actually checked.b
comment:59 Changed 11 years ago by
Description: | modified (diff) |
---|
- accuracy_goal
Implemented in r5003. (Also error_goal and relative_error_goal.)
OK, let's start working on this ...