whizard is hosted by Hepforge, IPPP Durham

Opened 14 years ago

Last modified 11 years ago

#418 closed defect

W1 option take-over into W2 — at Version 53

Reported by: Juergen Reuter Owned by: kilian
Priority: P1 Milestone: v2.2.0
Component: core Version: 2.0.5
Severity: normal Keywords: W1 -> W2 options
Cc:

Description (last modified by kilian)

  1. events_per_file, including starting number, for some formats
  2. show_* for debug output format

implemented in 2.1, not yet in 2.2

  1. fragment/fragmentation_method
  2. plot_width, plot_height
  3. accuracy_goal
  4. keep best grid as fall back option like W1
  5. allow to ignore checksum test

obsolete:

  1. use_efficiency (efficiency fluctuates)
  2. time_limit_adaptation (dangerous and machine dependent)
  3. generate_phase_space (old development flag)
  4. write_phase_space_channels_file
  5. extra_off_shell_lines
  6. splitting_depth (only single logs, not important)
  7. single/double_off_shell_branchings/decays
  8. massive_fsr
  9. single/double_off_shell_branchings/decays
  10. write_weights/write_weights_file
  11. guess_color_flow
  12. pythia_processes
  13. time_limit (only for hard nosed batch systems)
  14. warn_empty_channel (only for pathological cases)
  15. show_pythia_initialization
  16. show_pythia_statistics
  17. screen_events, screen_histograms
  18. screen_diagnostics
  19. plot_grids_channels, plot_grids_logscale (impractical for large number of channels?)

Change History (53)

comment:1 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:2 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:3 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:4 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:5 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:6 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:7 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:8 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:9 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:10 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:11 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:12 Changed 14 years ago by Juergen Reuter

Description: modified (diff)
Priority: P3P1

comment:13 Changed 14 years ago by Juergen Reuter

Description: modified (diff)

comment:14 Changed 14 years ago by ohl

Description: modified (diff)

comment:15 Changed 14 years ago by ohl

Description: modified (diff)

comment:16 Changed 14 years ago by ohl

Description: modified (diff)

comment:17 Changed 14 years ago by ohl

Description: modified (diff)

comment:18 Changed 14 years ago by ohl

Description: modified (diff)

comment:19 Changed 14 years ago by ohl

Description: modified (diff)

comment:20 Changed 14 years ago by ohl

Description: modified (diff)

comment:21 Changed 14 years ago by ohl

Description: modified (diff)

comment:22 Changed 14 years ago by ohl

Description: modified (diff)

comment:23 Changed 14 years ago by ohl

Description: modified (diff)

comment:24 Changed 14 years ago by ohl

Description: modified (diff)

comment:25 Changed 14 years ago by ohl

Description: modified (diff)

comment:26 Changed 14 years ago by ohl

Description: modified (diff)

comment:27 Changed 14 years ago by ohl

Description: modified (diff)

comment:28 Changed 14 years ago by ohl

Description: modified (diff)

comment:29 Changed 14 years ago by ohl

Description: modified (diff)
Summary: Discuss W1 option take-over into W2W1 option take-over into W2

comment:30 Changed 13 years ago by Juergen Reuter

Milestone: v2.0.6v2.0.7

comment:31 Changed 13 years ago by Juergen Reuter

Milestone: v2.1.0v2.0.7

comment:32 Changed 13 years ago by Juergen Reuter

Owner: changed from ALL to kilian

comment:33 Changed 13 years ago by kilian

Status: newassigned

OK, let's start working on this ...

comment:34 Changed 13 years ago by kilian

accuracy_goal: done in r3658.

There are now three goals: accuracy_goal, error_goal, relative_error_goal. If all goals that are set have been reached in the adaptation pass, the rest of the adaptation pass is skipped and WHIZARD proceeds with the final integration pass.

The nontrivial part was to make this work correctly with iterations read from file. They are reused where possible, even if the goals are changed in a second run.

comment:35 Changed 13 years ago by Juergen Reuter

Description: modified (diff)

comment:36 Changed 13 years ago by Juergen Reuter

Description: modified (diff)

comment:37 Changed 13 years ago by kilian

Description: modified (diff)
Priority: P1P3

comment:38 Changed 13 years ago by Juergen Reuter

Type: enhancementdefect

Those are actually defects as features that have been damaged or crippled.

comment:39 Changed 13 years ago by Juergen Reuter

Milestone: v2.0.7v2.0.8

comment:40 Changed 13 years ago by Juergen Reuter

Priority: P3P2

One of the last remaining things from W1.

comment:41 Changed 13 years ago by Juergen Reuter

Actually, I just had needed option 2 of the remaining tasks :(

comment:42 Changed 13 years ago by Juergen Reuter

Priority: P2P1

Well, I need them now(ish)

comment:43 Changed 13 years ago by Juergen Reuter

Milestone: v2.0.8v2.1.0

comment:44 Changed 12 years ago by Juergen Reuter

Milestone: v2.1.1v2.1.2

comment:45 Changed 12 years ago by Juergen Reuter

Milestone: v2.2.0v2.2.1

comment:46 Changed 12 years ago by Juergen Reuter

After the upgrade from WHIZARD 2.1.x to 2.2.0 we have to recheck again that all these options are in :(

comment:47 Changed 12 years ago by Juergen Reuter

Milestone: v2.2.1v2.2.0

comment:48 Changed 11 years ago by Juergen Reuter

Milestone: v2.2.0v2.2.1

comment:49 Changed 11 years ago by Juergen Reuter

Milestone: v2.2.1v2.2.0

W1 -> W2.1.x -> W2.2.x .... :(

comment:50 Changed 11 years ago by kilian

Since this is already assigned, I might just do it now ...

comment:51 Changed 11 years ago by Juergen Reuter

Cool. And please don't forget to re-check those features marked as implemtented here again.

comment:52 Changed 11 years ago by kilian

Description: modified (diff)

r4981 covers

  1. safety_factor, flag events w/weight > 1 (plot_excess)

Event weight excess in rejection (unweighting) is now always recorded and displayed at the end of the simulation pass. A safety_factor may be given to the simulate command to reduce the acceptance probability and thus reduce excess. Event excess can be separately plotted using record_excess. This offers more flexibility than the W1 version, where it was always plotted on top of the unweighted events. (Assuming that the drawing options will be improved in future versions, anyway.)

comment:53 Changed 11 years ago by kilian

Description: modified (diff)

Partially done:

  1. events_per_file, including starting number

Implemented for the eio_ascii set of formats. The global variables are sample_split_n_evt and {{sample_split_index}}}. Not yet implemented for other formats, but this should be straightforward. the relevant TBP is called eio_split_out.

Also done:

  1. signal handling: save/restore vamp grid CONTENTS

Signals are blocked by default. At important points in code, the signal status is queried by signal_is_pending and, if necessary, the current routine returns. This works like a poor-man's exception mechanism. The actual termination points are after each SINDARIN command. (In the cascades module, I kept termination points as they were before.)

This way of treating signals allows to do some cleanup, such as properly closing event files, before the program aborts. In the previous implementation, there was only the possibility of immediate abort at various points.

The issue of snapshooting VAMP is nontrivial. I deferred this to #572.

There are no tests for signal handling; this is difficult. Practice should show whether I missed something.

Note: See TracTickets for help on using tickets.