Opened 11 years ago
Closed 10 years ago
#530 closed feature_request (fixed)
Improve support for event formats
Reported by: | kilian | Owned by: | Juergen Reuter |
---|---|---|---|
Priority: | P2 | Milestone: | v2.2.3 |
Component: | core | Version: | 2.1.1 |
Severity: | normal | Keywords: | |
Cc: |
Description (last modified by )
We agreed that this is the remaining major issue for an alpha pre-release of 2.2.0.
The most important formats, in order of priority: [ 1. Raw format (done, but still subject to incompatible changes and improvements). Done, except for separate ticket #627] [ 2. LHEF . Done, except for separate ticket #570.] [ 3. HepMC (see #506), done except for ticket #647.]
- Stdhep and various ASCII formats, if still in use. Done except for
reading and reconstructing. [ 5. LCIO (see #439) and other new formats. -> separate ticket, probably done by WK's BSc]
Minimum is 1. and 2.
Change History (16)
comment:1 Changed 11 years ago by
Priority: | P0 → P1 |
---|
comment:2 Changed 11 years ago by
Status: | new → assigned |
---|
In r4652, I added support for (potentially varying) alpha_s values in the LHEF output.
The corresponding test lhef_2 also digs up a bug: the color connections of initial particles are missing. Should be tackled first, then HepMC output. LHEF/HepMC input can wait.
comment:3 Changed 11 years ago by
The color connections have been fixed in r4654. The next issue is HepMC (for output).
comment:4 Changed 11 years ago by
Priority: | P1 → P3 |
---|
As of r4672, there are both LHEF and HepMC available for output.
Minor issues remaining:
- The functional tests for HepMC do not check the file contents. I should filter out the HepMC version number, to get a portable check.
- HepMC does not respect keep_beams (that is probably ok, to be confirmed)
- The checks rely on the HepMC event format being fixed and include all digits from the numerics. They may fail for quadruple precision or for other HepMC versions. If this turns out to be non-portable, the check would have to rely on reading the file again and comparing the event data in WHIZARD's own format.
The updated priority list is as follows:
- Address the above HepMC issues.
- Implement further formats as supported by 2.1
- Add input form for LHEF and HepMC
- New event formats (LCIO)
comment:5 Changed 11 years ago by
comment:6 Changed 11 years ago by
Priority: | P3 → P1 |
---|---|
Severity: | normal → critical |
Stalled. Too many features have been broken away from 2.1.1.
comment:7 Changed 11 years ago by
It looks like Hepevt, Athena, Mokka, long and short ASCII formats are successfully reimplemented. LHA still is not correct, we have new ASCII default and debug formats. File endings have to be reenabled, and the two different stdhep formats.
comment:8 Changed 11 years ago by
File endings done in r4803. Next are checks about LHA and the verbose versions of LHA and HEPEVT, then STDHEP and STDHEP_UP.
comment:9 Changed 11 years ago by
LHA is working as intended. Next will be the two verbose output formats for HEPEUP and HEPEVT data blocks.
comment:10 Changed 11 years ago by
Owner: | changed from kilian to Juergen Reuter |
---|---|
Status: | assigned → new |
Some reshuffling in r4804 should establish the roles of the various sqme and weight numbers floating around. The handling of event is then well defined (in code, at least), and I'll leave the formats to JR for now, d'accord?
comment:11 Changed 11 years ago by
Status: | new → assigned |
---|
I wanted to reassign that ticket to myself, but didn't dare to :P Now, verbose HEPEVT and LHA are done. Next is STDHEP with HEPEVT and HEPEUP based setup. However, I don't really know how to write a unit test for this.
comment:12 Changed 11 years ago by
Milestone: | v2.2.0 → v2.2.1 |
---|---|
Owner: | changed from Juergen Reuter to kilian |
Status: | assigned → new |
Type: | defect → enhancement |
Finally, STDHEP is implemented again in both versions, including tests. Unit tests are very simplistic as there is no XDR reader for those files to check them.
Open points are: 1) XDR reader for proper STDHEP unit tests (shall we do this at all?) 2) Reading events back in from ASCII and STDHEP formats.
Both are enhancements/tasks left for 2.2.1.
comment:13 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:14 Changed 11 years ago by
Owner: | changed from kilian to Juergen Reuter |
---|---|
Priority: | P1 → P0 |
Status: | new → assigned |
I'll try my luck with this one now.
comment:15 Changed 11 years ago by
Description: | modified (diff) |
---|---|
Milestone: | v2.2.2 → v2.2.3 |
Priority: | P0 → P2 |
Severity: | critical → normal |
Summary: | Revive event formats → Improve support for event formats |
Type: | enhancement → feature_request |
comment:16 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
r4613: LHEF implemented for output. This should suffice for a first workable version.